This repository was archived by the owner on Feb 4, 2025. It is now read-only.
[Dynamic Dashboard] Fetch orders #3008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
approved these changes
May 10, 2024
There was a problem hiding this comment.
Nice work @0nko, I left a minor np, but feel free to ignore it.
| orderBy: OrderBy = OrderBy.DATE, | ||
| sortOrder: SortOrder = SortOrder.DESCENDING, | ||
| statusFilter: String? = null, | ||
| deleteOldData: Boolean = false |
There was a problem hiding this comment.
minor np, I suggest setting this to be page == 1 just to make it more suitable for any pagination by default, it's not something we need, but it could be more clear for any other usages in the future, WDYT?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements woocommerce/woocommerce-android#11462. This PR adds a way to add to fetch orders using coroutines without deleting the existing data.
To test:
Please test the associated WCAndroid PR.